Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase required memory resources for Docker #3452

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

andracc
Copy link
Collaborator

@andracc andracc commented Nov 15, 2024

Docker memory allocation should be set to at least 6 GB to handle increased helm chart resource requests.

This change is Reviewable

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.63%. Comparing base (6e1b47c) to head (92cf311).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3452   +/-   ##
=======================================
  Coverage   74.62%   74.63%           
=======================================
  Files         285      285           
  Lines       10999    10999           
  Branches     1339     1339           
=======================================
+ Hits         8208     8209    +1     
+ Misses       2407     2406    -1     
  Partials      384      384           
Flag Coverage Δ
backend 83.64% <ø> (+0.01%) ⬆️
frontend 66.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andracc andracc requested a review from imnasnainaec November 15, 2024 23:32
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andracc)

@andracc andracc marked this pull request as ready for review November 16, 2024 00:34
@andracc andracc merged commit 9238e55 into master Nov 16, 2024
18 checks passed
@andracc andracc deleted the docker-memory-limit branch November 16, 2024 00:36
@andracc andracc changed the title Adjust README to reflect new Docker memory requirements Increase required memory resources for Docker Nov 16, 2024
@andracc andracc self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants